fury icon indicating copy to clipboard operation
fury copied to clipboard

Updating animation tutorials

Open m-agour opened this issue 3 years ago • 2 comments

In this PR, I'm updating tutorials of FURY animation. It's still in progress (Fix few issues Filipi discovered through last zoom meeting) then, it's good to go.

m-agour avatar Sep 07 '22 12:09 m-agour

Codecov Report

Merging #680 (c4d7ca5) into master (8710a65) will decrease coverage by 0.07%. The diff coverage is 0.00%.

:exclamation: Current head c4d7ca5 differs from pull request most recent head 7a07367. Consider uploading reports for the commit 7a07367 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
- Coverage   50.47%   50.40%   -0.08%     
==========================================
  Files         126      120       -6     
  Lines       28299    27194    -1105     
  Branches     3034     3005      -29     
==========================================
- Hits        14284    13706     -578     
+ Misses      13536    13025     -511     
+ Partials      479      463      -16     
Impacted Files Coverage Δ
fury/animation/tests/test_timeline.py 0.00% <0.00%> (ø)
fury/animation/timeline.py 0.00% <0.00%> (ø)
fury/fury/animation/timeline.py 58.47% <0.00%> (-18.04%) :arrow_down:
fury/fury/tests/test_window.py 71.42% <0.00%> (-10.68%) :arrow_down:
fury/fury/shaders/base.py 84.84% <0.00%> (-8.09%) :arrow_down:
fury/fury/window.py 73.98% <0.00%> (-5.80%) :arrow_down:
fury/fury/animation/tests/test_timeline.py 98.61% <0.00%> (-1.39%) :arrow_down:
fury/fury/tests/test_pick.py 12.80% <0.00%> (-0.41%) :arrow_down:
fury/fury/ui/tests/test_elements.py 80.39% <0.00%> (-0.22%) :arrow_down:
fury/fury/ui/tests/test_containers.py 64.76% <0.00%> (-0.16%) :arrow_down:
... and 33 more

codecov[bot] avatar Sep 07 '22 12:09 codecov[bot]

Hello @filipinascimento, I added the hierarchical animation tutorial we discussed last meeting. Can you check it if you have time and let me know it it needs any changes?

m-agour avatar Oct 07 '22 20:10 m-agour

Rebase please.

Garyfallidis avatar Nov 24 '22 04:11 Garyfallidis

Sorry @Garyfallidis I am having my final midterm exam today, I will rebase all the animation PRs when I get back or by tomorrow.

m-agour avatar Nov 24 '22 05:11 m-agour

Last animation PR that needs some works. Can you fix the conflicts, rebase this PR, then I will be able to review it.

Thank you @m-agour

skoudoro avatar Dec 05 '22 20:12 skoudoro