fury
fury copied to clipboard
[WIP] Adding ability to load glTF animations
[WIP] This PR is still in progress.
It adds ability to load animation data from glTF files.
TODO
- Docstrings
- Tests
Check out this example (merged with PR #626) to see the animation.
Codecov Report
Merging #643 (0033d71) into master (db9771c) will decrease coverage by
0.08%
. The diff coverage is0.00%
.
:exclamation: Current head 0033d71 differs from pull request most recent head bab54fa. Consider uploading reports for the commit bab54fa to get more accurate results
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
- Coverage 50.40% 50.31% -0.09%
==========================================
Files 120 120
Lines 26830 27487 +657
Branches 2972 3049 +77
==========================================
+ Hits 13523 13831 +308
- Misses 12847 13196 +349
Partials 460 460
Impacted Files | Coverage Δ | |
---|---|---|
fury/gltf.py | 0.00% <0.00%> (ø) |
|
fury/transform.py | 0.00% <0.00%> (ø) |
|
fury/fury/gltf.py | 78.80% <0.00%> (-7.61%) |
:arrow_down: |
fury/fury/ui/helpers.py | 96.34% <0.00%> (-1.88%) |
:arrow_down: |
fury/fury/stream/tools.py | 90.94% <0.00%> (-0.22%) |
:arrow_down: |
fury/lib.py | 0.00% <0.00%> (ø) |
|
fury/actor.py | 0.00% <0.00%> (ø) |
|
fury/fury/lib.py | 100.00% <0.00%> (ø) |
|
fury/ui/helpers.py | 0.00% <0.00%> (ø) |
|
fury/ui/elements.py | 0.00% <0.00%> (ø) |
|
... and 11 more |
Hello @xtanion , This looks so good! I tested the example and the animation is working. Great job.
https://user-images.githubusercontent.com/63170874/180843664-3fb03ed3-f367-4bae-ae07-27535ae9e506.mp4
Thank you @xtanion. Please, update the description and warn us that the status of this PR is still in work in progress. You still need to do many updates, add some tests, docstring, etc...
Hello @xtanion! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:
Comment last updated at 2022-09-11 14:37:57 UTC
Can you provide some feedback for this @xtanion? thank you
I'm cleaning the PR and documenting it. It shall be done by tomorrow.
this PR needs still some work but I will go ahead and merge it.
Can you add a test for interpolator.py
in a new PR @xtanion. Thanks