fury icon indicating copy to clipboard operation
fury copied to clipboard

Resolving icon flaw in comboBox2D

Open lej0hn opened this issue 3 years ago • 3 comments

Fixing bug mentioned in #562

lej0hn avatar Apr 18 '22 19:04 lej0hn

Hello @lej0hn! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2022-04-19 17:01:37 UTC

pep8speaks avatar Apr 18 '22 19:04 pep8speaks

Hi @skoudoro , Pep8 issues have been resolved and the test is coming soon!

lej0hn avatar Apr 19 '22 17:04 lej0hn

Codecov Report

Merging #576 (001c492) into master (a7c31ae) will increase coverage by 0.26%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
+ Coverage   88.60%   88.87%   +0.26%     
==========================================
  Files          55       55              
  Lines       10957    11375     +418     
  Branches     1081     1122      +41     
==========================================
+ Hits         9708    10109     +401     
- Misses        954      965      +11     
- Partials      295      301       +6     
Impacted Files Coverage Δ
fury/fury/data/fetcher.py 71.03% <0.00%> (-1.38%) :arrow_down:
fury/fury/layout.py 98.63% <0.00%> (-1.37%) :arrow_down:
fury/fury/tests/test_utils.py 94.26% <0.00%> (-0.74%) :arrow_down:
fury/fury/actor.py 88.15% <0.00%> (-0.17%) :arrow_down:
fury/fury/ui/elements.py 87.21% <0.00%> (-0.09%) :arrow_down:
fury/fury/lib.py 100.00% <0.00%> (ø)
fury/fury/ui/helpers.py 98.21% <0.00%> (ø)
fury/fury/tests/test_layout.py 100.00% <0.00%> (ø)
fury/fury/tests/test_material.py 100.00% <0.00%> (ø)
fury/fury/tests/test_primitive.py 100.00% <0.00%> (ø)
... and 6 more

codecov[bot] avatar Apr 19 '22 18:04 codecov[bot]

superseded by #768, closing

skoudoro avatar Jun 12 '23 16:06 skoudoro