Resolving GridUI caption error

[ganimtron-10]

Fixing Bug mentioned at #463.

[codecov[bot]]

Codecov Report

Merging #478 (bc728cc) into master (8710a65) will decrease coverage by 0.29%. The diff coverage is 0.00%.

:exclamation: Current head bc728cc differs from pull request most recent head dbc4176. Consider uploading reports for the commit dbc4176 to get more accurate results

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   50.47%   50.19%   -0.29%     
==========================================
  Files         126      120       -6     
  Lines       28299    28033     -266     
  Branches     3034     2989      -45     
==========================================
- Hits        14284    14071     -213     
+ Misses      13536    13495      -41     
+ Partials      479      467      -12     

Impacted Files	Coverage Δ
fury/actor.py	0.00% <0.00%> (ø)
fury/fury/tests/test_window.py	71.54% <0.00%> (-10.56%)	:arrow_down:
fury/fury/animation/timeline.py	66.08% <0.00%> (-10.43%)	:arrow_down:
fury/fury/shaders/base.py	84.84% <0.00%> (-8.09%)	:arrow_down:
fury/fury/window.py	74.14% <0.00%> (-5.63%)	:arrow_down:
fury/fury/animation/tests/test_timeline.py	98.61% <0.00%> (-1.39%)	:arrow_down:
fury/fury/actor.py	88.25% <0.00%> (-0.58%)	:arrow_down:
fury/fury/ui/elements.py	89.66% <0.00%> (-0.07%)	:arrow_down:
fury/gltf.py	0.00% <0.00%> (ø)
fury/window.py	0.00% <0.00%> (ø)
... and 11 more

[ganimtron-10]

I have added tests for the changes.

[skoudoro]

Thank for the update @ganimtron-10!

ping @antrikshmisri

[ganimtron-10]

Thanks @antrikshmisri for the review! I have made changes according to the comments. Thanks!

[antrikshmisri]

Hey @ganimtron-10, thanks for the update. LGTM.

[ganimtron-10]

Hii @antrikshmisri !! Is there any thing left to be changed in this pr??

[ganimtron-10]

Hello @skoudoro , Any updates on this?

[ganimtron-10]

Hello @skoudoro , Thanks for the update!

Last time, I just got confused between the return type of the grid function and the type of the items as I thought the grid function is inconsistent (ie. which returns either Container or Actor) due to which I implemented that approach, but this isn't the case.

Now I have updated the PR and made changes into the GridUI itself. PTAL.

[skoudoro]

@ganimtron-10, this PR is almost ready to be merged.

See my comment above. Can you update the tests? Thank you!

[ganimtron-10]

Hello @skoudoro , I tried creating a similar test and as per the older conversation used try and except block to test whether it throw error or not. Please let me know if its correct or not.

[ganimtron-10]

Hey @skoudoro , I have updated the tests and they are now passing on macOS.

[skoudoro]

Thank you for this @ganimtron-10, looks good!