fury icon indicating copy to clipboard operation
fury copied to clipboard

ListBox2D resize implementation

Open Nibba2018 opened this issue 5 years ago • 8 comments

Is your feature request related to a problem? Please describe. Implemention of resize method for ListBox2D.

Describe the solution you'd like Executing listbox.resize((width, height)) should resize the listbox accordingly.

Additional context This method will be useful for ComboBox2D and FileMenu2D as well.

Nibba2018 avatar Jun 10 '20 16:06 Nibba2018

@Nibba2018 I would like to work on it. Could you please assign this to me & provide a bit more info. Thanks !

SanjayMarreddi avatar Nov 20 '20 17:11 SanjayMarreddi

@SanjayMarreddi Sure, go ahead. The objective is to make sure that the UI components which renders ListBox2D, such as slots, scrollbar etc, should resize along with ListBox2D. Try to understand how the resize method works for other UI components, specifically the TabPanel2D one.

Nibba2018 avatar Nov 20 '20 18:11 Nibba2018

@Nibba2018 I tried Implementing resize function in ListBox2D Class of ui.py File. For testing that function, I used this Tutorial on ListBox and added this line

listbox.resize((100,100))

after the line

values = ["Welcome", "Bye", "Fury"]
listbox = ui.ListBox2D(
    values=values, position=(10, 300), size=(200, 200), multiselection=False
)

This way of testing is correct only right ?

If not, Actually, I am not able to find any resizing happening. Can I make a PR so that you can review it & help me in proceeding further ?

Thanks !

SanjayMarreddi avatar Nov 26 '20 13:11 SanjayMarreddi

@SanjayMarreddi The resize method for ListBox2D is not yet implemented that why this issue was created. We need to implement that method.

Nibba2018 avatar Nov 26 '20 13:11 Nibba2018

@Nibba2018 I am saying that I implemented the Function resize function in my Local System & tried testing that using the above Tutorial

SanjayMarreddi avatar Nov 26 '20 13:11 SanjayMarreddi

@SanjayMarreddi I see, okay then make a PR and I will review it.

Nibba2018 avatar Nov 26 '20 14:11 Nibba2018

If no one is working on this issue, Can I work on this??

ganimtron-10 avatar Apr 14 '21 10:04 ganimtron-10

@ganimtron-10 Sure, I am currently busy with other works. You can ask the maintainers to assign this to you & then you can start working on it. I will join in later on if it was not resolved till then. Good Luck!

SanjayMarreddi avatar Apr 14 '21 13:04 SanjayMarreddi