Matias Furszyfer
Matias Furszyfer
Currently, if users provide a double negated value such as '-nowallet=0' or a non-boolean convertible value to a negated option such as '-nowallet=not_a_boolean', the initialization process results in a fatal...
Because AssumeUTXO nodes prioritize tip synchronization, they relay their local address through the network before completing the background chain sync. This, combined with the advertising of full-node service (`NODE_NETWORK`), can...
Following changes were made: 1) Catch and signal error for duplicate string destinations. 2) Catch and signal error for invalid value type. 3) Catch and signal error for string destination...
Expands the benchmark framework with the existing `-testdatadir` arg, enabling the ability to change the benchmark data directory. This is useful for running benchmarks on different storage devices, and not...
A more comprehensive fix for the issue described in #837. Since the `WalletModel` class is unavailable when compiling without wallet support `(-DENABLE_WALLET=0)`, the RPC executor class should not be coupled...
Part of the legacy wallet removal working path #20160. Stops creating a bdb database in the wallet migration benchmark. Instead, the benchmark now creates the db in memory and re-uses...
Useful for debugging issues such https://github.com/bitcoin/bitcoin/pull/31241#issuecomment-2462816933. Prints the entire response content instead of printing only the position of the byte it can't be decoded. The diff between the error messages...
Ensure legacy wallet migration skips the never standard bare multisig with +3 keys and consensus-invalid multisig scripts. Treating them as valid causes migration to crash because we are enforcing this...
The crash occurs because we assume the cached scripts structure will not be empty, but it can be empty for watch-only wallets that start blank. This also adds test coverage...
Currently, the migration process creates a brand-new descriptor wallet with no connection to the user's legacy wallet when the legacy wallet lacks key material and contains only watch-only scripts. This...