Matias Furszyfer

Results 52 issues of Matias Furszyfer

This issue will be edited frequently to reflect the current status of the project. #### What should I review now?
 👇 👇 👇 👇 -- #30118 -- ☝️ ☝️ ☝️...

If the transaction includes an output that goes to the custom change address (`CoinControl::destChange`), the transaction creation process should avoid creating duplicate outputs to the same address. Instead, it should...

Wallet
Needs rebase
CI failed

Quick follow-up to #28610, coming from https://github.com/bitcoin/bitcoin/pull/28610#pullrequestreview-1802823938. Verifying that the 'replaced_by_txid' and 'replaces_txid' tx data is preserved after migration, as well as the extra tx comments.

Tests

Implemented `getblockfileinfo` RPC command to obtain block files related data. The new RPC could be useful for: 1) Make manual pruning process more transparent: Currently, users blindly provide a height...

RPC/REST/ZMQ
CI failed

Depends on https://github.com/bitcoin/bitcoin/pull/27601, please go there first. This work aims to define, and implement a base standard mechanism to detect individual change outputs. ### Context Currently, the wallet detects whether...

Wallet

Discovered while was reviewing #29112, specifically https://github.com/bitcoin/bitcoin/pull/29112#pullrequestreview-1821862931. If the db handler that initiated the database transaction is destroyed, the ongoing transaction cannot be left dangling when the db txn fails...

Wallet

Coming from #27652, part of #29183. The general idea is to keep track of the user requested blocks so, in case of a bad behaving peer or a network disconnection,...

P2P
CI failed

Commits decoupled from #28574, focused on the address book cloning process Includes: 1) DB batch operations and flow simplification for the address book migration process. 2) Code improvements to `CWallet::DelAddressBook`...

Wallet

Fixes https://github.com/bitcoin/bitcoin/pull/29144#issuecomment-1907071391. The settings warning message is meant to be used only to discourage users from modifying the file manually. Therefore, there is no need to keep it in memory.

Seeks to optimize and simplify `WalletBatch::EraseRecords`. Currently, this process opens a cursor to iterate over the entire database, searching for records that match the type prefixes, to then call the...

Wallet