patchman icon indicating copy to clipboard operation
patchman copied to clipboard

Add Dockerfile with required settings

Open skatsaounis opened this issue 5 years ago • 4 comments

It addresses (#81)

skatsaounis avatar Apr 09 '20 13:04 skatsaounis

Hi @furlongm, if you think that this PR can have a future, I can rebase to current develop and tell me your opinion about it. In addition, I have developed a Helm Chart based on this Dockerfile and could also open a subsequent PR.

skatsaounis avatar Sep 22 '20 16:09 skatsaounis

Rebasing might make it clearer what's in the PR. I also have a Dockerfile that I was going to add in v2, and there a couple of others I know. Wondering if it might be sensible to just link to the various Dockerfiles rather than have one in the project?

furlongm avatar Sep 22 '20 17:09 furlongm

@furlongm I proceeded with the rebase. As you can see, the Dockerfile assumes that Patchman runs in Python2. If you are ready to make the transition to 3, it can be upgraded.

skatsaounis avatar Sep 23 '20 13:09 skatsaounis

@furlongm Hi Marcus. Did you have the chance to take a look here? This acts as a kind reminder.

skatsaounis avatar Nov 23 '20 06:11 skatsaounis