django-address icon indicating copy to clipboard operation
django-address copied to clipboard

Deprecate use of jquery from Django Address

Open banagale opened this issue 3 years ago • 4 comments

I've come to believe jquery should be eliminated from new software releases where possible.

django-address uses jquery in the javascript functions that perform the auto complete function, (jquery.geocomplete.js).

Does anyone have any strong feelings about keeping jquery in for any reason? Any chance someone is interested in taking on building a PR that finds a replacement or refactors the above library into pure ES 2015 plus vanilla JS?

banagale avatar Nov 20 '20 15:11 banagale

Good call, @banagale. Vanilla JS should be able to handle most of what's going on here. I wouldn't mind taking a stab at it.

abmohan avatar Feb 13 '21 01:02 abmohan

Okay @abmohan Please do post if you begin work on this / any status updates you're able to offer. I'll assign this to you for now, if it looks like it can't get done just let me know.

banagale avatar Feb 14 '21 00:02 banagale

Google offers its own Places Autocomplete Javascript library that handles the autocomplete feature on text inputs. 

Note, the packaged jQuery plugin was based off Google's geo-autocomplete which refers people to use the updated Google Maps V3 API instead.

Should be possible to update AddressWidget to excise jquery.

banagale avatar May 17 '21 00:05 banagale

Hey @banagale! I've got some time at the moment, I'll take a peek at how hard it might be to get Google's autocomplete library used here.

furious-luke avatar Aug 21 '21 03:08 furious-luke