Lucas Grzegorczyk

Results 94 comments of Lucas Grzegorczyk

[BUG] Wrong version number

For me personally as a new user not related to the project it makes more sense to have 7.2.5 version everywhere when I compile valkey. I'm thinking from a perspective...

[BUG] Wrong version number

You mean that it's 6.0.0 when the project was still redis? That's something for documentation, right? I mean, it's kept for historical reasons, you can go in this repo and...

Fix status report page

I'll check if I can cover this in a test case and edit the main post accordingly. EDIT: I could probably do it but definitely not today. I've been looking...

Querying by search term + pagination doesn't respect default sorting

Could it result in repeated results in pagination? Cause that's what I'm currently seeing on my end.

Timestamp format should match system time format

Why not just let user change the locale/date format in preferences? Does it really have to be pulled from system?

Add redis symlinks at the same place as the installed binaries

For me this change causes issues when using TLS. When I switch off symlinks for redis then installation fails cause it can't find `libhiredis_ssl.a`. Could this implementation be revisited?

Add redis symlinks at the same place as the installed binaries

I haven't had time to dig into it. What I'm doing is pretty simple, e.g.: ```bash make BUILD_TLS=yes USE_SYSTEMD=yes make PREFIX=custom/usr USE_REDIS_SYMLINKS=no install ``` And then it fails with error...

Issue with formatting and "\t" and "\n"

Isn't it weechat related?

Sun

Would be really nice to have. :)

fix(caldav): only call getTimestamp() on actual DateTime data

Isn't this line improperly formatted?