easy-gd icon indicating copy to clipboard operation
easy-gd copied to clipboard

Make easy-gd complient with Node 4.x.x

Open y-a-v-a opened this issue 9 years ago • 11 comments

Update node-gd to 1.1.0 and still get it to work with [email protected] also.

y-a-v-a avatar Oct 11 '15 21:10 y-a-v-a

Hey Vincent,

thanks for your PR. Probably it is worth to drop the old node.js versions support, so I will investigate the matter and merge.

furagu avatar Oct 12 '15 07:10 furagu

Hi thanks for the reply. Yes I think the build breaks for 0.9 and 0.8 due to changes in dependencies. As said, it builds and passes npm test for nodejs 4.1.2 and 0.12.7. No idea how it builds on 0.10.x. I think support for 0.12.x is still valuable, support for 0.10.x can be debatable ;-)

y-a-v-a avatar Oct 12 '15 09:10 y-a-v-a

i'm using this fork. Works great!

kaanon avatar Dec 09 '15 09:12 kaanon

Any news on whether this will be merged?

Spalland avatar Feb 28 '16 17:02 Spalland

Yes y-a-v-a Is working great !!!

MatthD avatar Mar 02 '16 16:03 MatthD

Ok so I modified the configuration for travis a bit so we drop support for nodejs 0.9. As travis shows, still builds nicely on 0.10, 0.12 and 4.3. If you don't mind dropping support for 0.9, you could merge this PR. Regards, Vincent

y-a-v-a avatar Mar 31 '16 20:03 y-a-v-a

@furagu any chance you have time to look into this PR / merge it / publish it to NPM? Would be great.

y-a-v-a avatar Apr 04 '16 07:04 y-a-v-a

Hi @furagu we've added some updates, extended nodejs version support. Could you merge & publish to npm? Or add me as a maintainer in npm so I could publish a new version myself? Thanks in advance!

y-a-v-a avatar Jun 29 '16 07:06 y-a-v-a

@furagu would be great if this could get merged (or if you could add y-a-v-a as a maintainer) on up to date systems with older versions of node I have an issue with node-gyp as it's not compatible with python3 which prevents me from installing easy-gd, on systems with a more recent version of node I can't install because easy-gd isn't compatible. This branch fixes the issue so would be really helpful to anyone in a similar situation.

dekatron avatar Aug 20 '16 11:08 dekatron

@furagu +1 for merging this or making @y-a-v-a a maintainer

kodie avatar Dec 16 '16 18:12 kodie

Updated easy-gd to use [email protected] and [email protected]

y-a-v-a avatar Sep 22 '17 11:09 y-a-v-a