deck-chores icon indicating copy to clipboard operation
deck-chores copied to clipboard

Update parsers.py

Open garrythezany opened this issue 3 years ago • 2 comments

Hello again!

If the container-labels for a single service are omitted, the deck-chores service fails and dies:

[...]
    labels:
       deck-chores.command: "echo hello"
       deck-chores.interval: "hourly"
[...]

The trailing commit fixes the service failing on misconfigured/broken job label definitions, and prints an error instead.

Sorry for missing / failing tests.

Thanks!

garrythezany avatar Feb 28 '22 13:02 garrythezany

sorry, but this certainly requires tests. i'm also having trouble to understand what your description and example have to do with the proposed change.

funkyfuture avatar Mar 01 '22 09:03 funkyfuture

A new coworker missspelled the label (forgot the naming part) and the parser broke the hole deck-chores container. The container fainted with a python split/parse error.

[...]
    labels:
       deck-chores.command: "echo hello"
       deck-chores.interval: "hourly"
[...]

VS

[...]
    labels:
       deck-chores.name-for-cron.command: "echo hello"
       deck-chores.name-for-cron.interval: "hourly"
[...]

Sadrak avatar Apr 27 '22 09:04 Sadrak