Hi, this PR is a continuation of https://github.com/funkia/hareactive/pull/76 (fully includes that changes, so #76 should be merged first). This PR enables TS strictNullChecks flag and contains corresponding changes. There're no breaking changes.

Apr 21 '20 16:04 raveclassic

Codecov Report

Merging #77 into master will increase coverage by 0.02%. The diff coverage is 96.10%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   96.22%   96.24%   +0.02%     
==========================================
  Files          13       13              
  Lines        1508     1517       +9     
  Branches      136      146      +10     
==========================================
+ Hits         1451     1460       +9     
  Misses         57       57

Impacted Files	Coverage Δ
src/testing.ts	`96.79% <91.17%> (+0.03%)`	:arrow_up:
src/behavior.ts	`98.30% <100.00%> (+0.02%)`	:arrow_up:
src/common.ts	`97.75% <100.00%> (+0.10%)`	:arrow_up:
src/datastructures.ts	`100.00% <100.00%> (ø)`
src/future.ts	`96.45% <100.00%> (ø)`
src/placeholder.ts	`91.13% <100.00%> (ø)`
src/stream.ts	`95.69% <100.00%> (+0.01%)`	:arrow_up:
src/time.ts	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d37fd70...009c49e. Read the comment docs.

Apr 21 '20 16:04 codecov[bot]

Also I don't get why codecov/patch fails, everything is fine on my local machine. UPD: ahhh, maybe I need to rebase instead of merging UPD2: nope, didn't help :(

May 09 '20 11:05 raveclassic

Does it make sense to continue on this? Is the only reason it is not merged yet the 0.12% missing test coverage of the patch? In case, I suggest to append this commit, covering some additional lines: https://github.com/DSoko2/hareactive/commit/163328b4af667a99af3d2f9541ec69be9453ccaf

Mar 07 '21 15:03 DSoko2

Enable strictNullChecks

Codecov Report