fh-components icon indicating copy to clipboard operation
fh-components copied to clipboard

Published 20 hours ago • verified publisher icon funkhaus

Add `autoplay` parameter on responsive-image

Open SaFrMo opened this issue 6 years ago • 5 comments

SaFrMo avatar Mar 26 '18 19:03 SaFrMo

Added in c9b264e

SaFrMo avatar May 21 '18 19:05 SaFrMo

I think I'm missing why this is needed, having this prop basically just turns the video into a still image. Why do we need it? And having it false by default might break older sites when they update, right?

johndigital avatar May 25 '18 16:05 johndigital

Good points! I think this was for responsive images that have video with sound attached, to get around new autoplay restrictions, but if we're using a video with sound it should probably be a video-stage anyway. And you're right that it would break older sites. I'll revert this commit for now and we can discuss more if it's needed - @lwaldner @drewbaker are there any good use cases you can think of?

SaFrMo avatar May 25 '18 16:05 SaFrMo

I'm not 100% sure what this controls, but the use case I'd want is to have a still image by default, then on hover it plays a video. Like on WhatYouth. Then when I hover on the same video again, it should start at the beginning again.

drewbaker avatar May 25 '18 18:05 drewbaker

That's definitely a use I hadn't thought of. With that in mind maybe we should keep the prop and just have it true by default?

johndigital avatar May 25 '18 18:05 johndigital