recept icon indicating copy to clipboard operation
recept copied to clipboard

Add reMarkable 1 support

Open Eeems opened this issue 2 years ago • 9 comments

I removed the precompiled binaries since it's not really best practice to include them in the source. Instead I'd recommend uploading a zip containing them and install.sh to a release tag.

Eeems avatar Feb 10 '23 21:02 Eeems

Fixes #13

Eeems avatar Feb 10 '23 21:02 Eeems

@funkey is there anything you'd like me to change before merging?

Eeems avatar Feb 19 '23 02:02 Eeems

Hi Nathaniel,

Thanks a lot for the PR. Adding RM1 support is great, happy to include that.

However, I don't want to remove the precompiled binaries. The reason I include them along the source is that not every user of recept might be able (or willing) to compile the code themselves. This will pose a barrier for most users.

So I suggest you either keep the precompiled binaries (they are tiny) or add a script to download them as you suggested. I'd very much prefer the former.

funkey avatar Feb 21 '23 14:02 funkey

Let me clarify, I wasn't suggesting a script to download them, I was suggesting adding an artifact to a release tag that users can download that contains the existing install.sh script, as well as the precompiled binaries.

I wouldn't mind taking some time to automate this with github actions if you'd like.

Eeems avatar Feb 21 '23 15:02 Eeems

I see. Sure, go ahead then, sounds good to me!

funkey avatar Feb 24 '23 15:02 funkey

Sorry for how long this took. I had some stuff come up. I've only automated the build here, but you should be able to automate creating a new version on merge to master, and attaching the build artifacts.

Eeems avatar May 04 '23 20:05 Eeems

Example run since you have to allow my pull request to run this: https://github.com/Eeems/recept/actions/runs/4887019353

Eeems avatar May 04 '23 20:05 Eeems

@funkey poke?

Eeems avatar Nov 26 '23 20:11 Eeems

@funkey poke again?

Eeems avatar Jan 11 '24 21:01 Eeems