fx-fotos icon indicating copy to clipboard operation
fx-fotos copied to clipboard

FEATURE REQUEST: Browsing single image with action buttons [OPEN TO HUNT] [$1,000]

Open ghorbani-m opened this issue 2 years ago • 42 comments

OPEN TO HUNTERS

Action Performed:

  1. Tap on an image to navigate to the single image view screen

Expected Result:

When the user navigated to the single image view screen, he/she has to be able to :

  1. Browse between images (Allow the user to scroll images horizontally in a single view mode)
  2. Zoom in/out the image
  3. View the image information when pulled up the image
  4. Display action buttons at the end of the screen

https://user-images.githubusercontent.com/16715868/162618847-7a14c950-5da1-4aa4-9575-9014393f25e9.mp4

Actual Result:

Till now We have created a single-image view screen to open the selected image with a transition on it. We have used react-native-shared-element and react-navigation packages to manage image transitions between screens.

https://user-images.githubusercontent.com/16715868/162619712-03192fd0-5c0a-4850-9ae8-863b69331956.mp4

Workaround:

Platform:

Where is this issue occurring?

  • iOS
  • Android

There is a $1,000 open bounty on this issue. Add to the bounty at Bountysource.

ghorbani-m avatar Apr 10 '22 13:04 ghorbani-m

is someone working on this? i'd be interested to implement this, but i don't want to waste efforts competing ;)

caryoscelus avatar Apr 25 '22 08:04 caryoscelus

Hi @caryoscelus , Thanks for your attention, Yes, someone is working on this issue.

ghorbani-m avatar Apr 25 '22 09:04 ghorbani-m

For anyone following, I've got the panel view working on IOS and Android, with a minor bug on IOS which I will address later.

I am now working on incorporating the panel and outputting real information similar to that in another similar application.

richard-fairthorne avatar May 10 '22 14:05 richard-fairthorne

@caryoscelus the person working on the issue did not deliver. If you want to start working on it please let me know

ehsan6sha avatar Jun 07 '22 21:06 ehsan6sha

This issue is open for bounty hunters

ehsan6sha avatar Jun 07 '22 21:06 ehsan6sha

@ehsan6sha i'm a little busy with other projects right now , i'll asses my resources and get back to you

caryoscelus avatar Jun 07 '22 21:06 caryoscelus

@ehsan6sha Can I pick this up?

priyeshshah11 avatar Jun 23 '22 22:06 priyeshshah11

@ehsan6sha Can I pick this up?

Hi, Sure. Can you please provide frequent updates

ehsan6sha avatar Jun 23 '22 22:06 ehsan6sha

@ehsan6sha Can I pick this up?

Hi, Sure. Can you please provide frequent updates

Sure, will do. Getting started! :)

priyeshshah11 avatar Jun 23 '22 22:06 priyeshshah11

Can I pick this one ?

vibhuti019 avatar Jun 27 '22 15:06 vibhuti019

Would like to work on this issue ! If the admin is okay with this ?

endurance21 avatar Jun 27 '22 17:06 endurance21

hi @priyeshshah11 please update us if you have started work on this issue?

ehsan6sha avatar Jun 27 '22 17:06 ehsan6sha

@endurance21 and @vibhuti019 I believe the way bountyhunt works is it allows multiple people work on the isue and provides the bounty to the accepted PR. Our criteria is performance and functionality.

ehsan6sha avatar Jun 27 '22 17:06 ehsan6sha

I could possibly work on this bounty too.

seanwestfall avatar Jun 27 '22 18:06 seanwestfall

hi @priyeshshah11 please update us if you have started work on this issue?

Hi @ehsan6sha Yes I tried, but had several setup issues on a Mac M1 Pro and have other priority stuff going on, so others can pick it up/start work.

priyeshshah11 avatar Jun 27 '22 19:06 priyeshshah11

@seanwestfall sure. as long as it is open, anyone can start the work

ehsan6sha avatar Jun 27 '22 20:06 ehsan6sha

@seanwestfall @vibhuti019 @endurance21 anyone who started working on it, might be a good idea to share the progress frequently

ehsan6sha avatar Jun 28 '22 14:06 ehsan6sha

I have created a view for single image view, working on the scroll action @ehsan6sha

vibhuti019 avatar Jun 29 '22 04:06 vibhuti019

@vibhuti019 any progress?

ehsan6sha avatar Jul 06 '22 22:07 ehsan6sha

I am working on it sir @ehsan6sha

vibhuti019 avatar Jul 07 '22 12:07 vibhuti019

I testable working PR will be ready within 2-3 days.

vibhuti019 avatar Jul 07 '22 12:07 vibhuti019

@ehsan6sha my iPhone is having problem can someone verify the app on iOS?

vibhuti019 avatar Jul 10 '22 16:07 vibhuti019

Hi @vibhuti019 , For now just Android platform is ready for build.

ghorbani-m avatar Jul 10 '22 17:07 ghorbani-m

I can confirm, when trying to build fotos in xcode I get this error:

unable to open file (in target "fotos" in project "fotos") Pods-fotos.debug.xcconfig

seanwestfall avatar Jul 11 '22 13:07 seanwestfall

@seanwestfall are you trying to use expo cli? There is some issue in code due to which expo is unable to fetch assets. We can raise a issue for this and then expo can compile the code for iOS.

vibhuti019 avatar Jul 13 '22 09:07 vibhuti019

@ghorbani-m @ehsan6sha can anyone give any idea for scroll-up function which shows the details of the pic. I have tried some things but it is causing errors.

vibhuti019 avatar Jul 13 '22 09:07 vibhuti019

@ghorbani-m @ehsan6sha can anyone give any idea for scroll-up function which shows the details of the pic. I have tried some things but it is causing errors.

@vibhuti019 have you got a build successfully on the develop branch? There is a screen called "Photo" here that displays a single image. and here is where we navigate to Photo screen

However, you have to create another screen, especially for the single image browsing feature.

ghorbani-m avatar Jul 13 '22 09:07 ghorbani-m

@ghorbani-m @ehsan6sha can anyone give any idea for scroll-up function which shows the details of the pic. I have tried some things but it is causing errors.

@vibhuti019 have you got a build successfully on the develop branch? There is a screen called "Photo" here that displays a single image. and here is where we navigate to Photo screen

However, you have to create another screen, especially for the single image browsing feature.

@ghorbani-m Exactly I have done the same I have created another screen for browsing image feature buy I am unable to use the scroll up feature which will show the details of thr image. The last part is causing issues and also let me know what details I will have to show.

vibhuti019 avatar Jul 13 '22 10:07 vibhuti019

@vibhuti019 You need to implement this feature by react-native-reanimated and react-native-gesture-handler, For now, you can just display the image path, create date, and modified the date.

Sorry, I don't get the scroll-up issue, you mean, you can not implement this part of feature?

ghorbani-m avatar Jul 13 '22 10:07 ghorbani-m

No, I am working on it. While using the gesture handler it wasn't working on apple devices. And was causing constant errors. I will try with the second one today.

vibhuti019 avatar Jul 13 '22 12:07 vibhuti019