functime icon indicating copy to clipboard operation
functime copied to clipboard

fix: Polars >=1.0 fixes, kindly provided by tjader in https://github.…

Open fabianbergermann opened this issue 8 months ago • 4 comments

…com/functime-org/functime/pull/256

NOTE: this is only a slightly updated copy from the original PR - all credits go to the original author and the original PR

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This PR fixes all issues with Polars >= 1.0 caught by existing tests.

Has been tested with Polars 1.8.2.

Any other comments?

All issues found were listed in polars' upgrade guide https://docs.pola.rs/releases/upgrade/1/, so versions of polars between 1.0 and 1.8.2 should be fine.

fabianbergermann avatar Apr 21 '25 10:04 fabianbergermann

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2025 1:07pm

vercel[bot] avatar Apr 21 '25 10:04 vercel[bot]

Perhaps there is scope to fork this project and support the development with a fresh pypi package?

firmai avatar May 06 '25 21:05 firmai

Hi,

Thanks for pushing the code and make it compatible with polars >= 1.0

I contacted @baggiponte and we are going to test this weekend and hopefully merge it by then.

Keep posted 👍

MathieuCayssol avatar Oct 01 '25 08:10 MathieuCayssol

Hello there, thanks @MathieuCayssol for the ping. Let's ship v0.9 with polars >=1 support.

This review is going to take a bit of time since there's a lot to unpack.

Python 3.9 support is reaching end of life this month but I think we should address this in a separate issue (although soon). Any opinions on this? Would it be too hard to decouple this PR from the 3.9 support? I see polars is still supporting py3.9.

baggiponte avatar Oct 01 '25 09:10 baggiponte