functime icon indicating copy to clipboard operation
functime copied to clipboard

fix: numpy precision

Open jhug12 opened this issue 1 year ago • 2 comments

Fixes #225

Summary

Changes precision from float32 to float64 for conversion from polars DataFrame to numpy ndarray

jhug12 avatar Jun 07 '24 10:06 jhug12

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
functime-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 10:43am

vercel[bot] avatar Jun 07 '24 10:06 vercel[bot]

Ciao @jhug12, sorry for being late and thanks for the great PR.

I merged a few things in the codebase: would you mind rebasing your PR?

Also: I see you committed other fixes and improvements (thanks once more 🤗) but I am not sure whether they relate to this PR. I can help you with putting some changes in other pull requests, as they will be easier to review.

(I was actually thinking whether we should just map the datatypes that come in and when we perform the conversion just respect those, and raise a warning if they're not F64)

baggiponte avatar Jun 09 '24 21:06 baggiponte