onnx-pytorch icon indicating copy to clipboard operation
onnx-pytorch copied to clipboard

Add Tanh, Range and Pow OpCodeGenerators and fix assert when dir exists

Open alealv opened this issue 3 years ago • 4 comments

alealv avatar Jul 21 '21 09:07 alealv

@alealv Here is the assert fix: Change /home/username/venvonnx/lib/python3.8/site-packages/onnx_pytorch/code_gen.py You already have a soln. For others out there... def gen(onnx_model, output_dir, overwrite=False, tensor_inplace=False, simplify_names=False, continue_on_error=False): kwargs = { "output_dir": output_dir, "simplify_names": simplify_names, "tensor_inplace": tensor_inplace, "continue_on_error": continue_on_error, } if type(onnx_model) == onnx.ModelProto: kwargs["onnx_model"] = onnx_model else:

        if os.path.exists(output_dir):
            pathExists = True
            print(f"{output_dir} exists.")
        else:
            pathExists = False
            print(f"{output_dir} does not exists.")
        print(f"overwrite: {overwrite}")

        assert os.path.exists(
            onnx_model), f"ONNX model {onnx_model} does not exist."
        assert os.path.isfile(onnx_model), f"{onnx_model} is not a file."

        if pathExists and overwrite != True:
            print(f"{output_dir} exists and overwrite is not True.")

        if os.path.exists(output_dir):
            assert overwrite, f"{output_dir} exists and overwrite is not True."

        assert os.path.isdir(output_dir), f"{output_dir} is not directory."
        kwargs["onnx_model"] = onnx.load(onnx_model)
    if overwrite:
        shutil.rmtree(output_dir, ignore_errors=True)
        os.makedirs(output_dir)
    ModelCodeGenerator(**kwargs).run()

Z223I avatar Jul 31 '21 22:07 Z223I

@alealv Thanks for contribution. Maybe conflict with earlier PR, just wait to merge.

fumihwh avatar Aug 16 '21 08:08 fumihwh

Sorry for the late reply. I didn't get your answer, what do you want me to change?

I just rebase to master.

alealv avatar Aug 26 '21 09:08 alealv

@alealv Could you add test cases for pow and range op?

fumihwh avatar Aug 28 '21 10:08 fumihwh