Jack Langston
Jack Langston
@whynowy There appears to be some nondeterminism in the unit test at `pkg/sensors/triggers/kafka/kafka_test.go:198`. The CI runner is showing it as failing but I am not able to reproduce the failure...
@whynowy For the linting, I am not sure what is wrong, and some assistance would be appreciated. When I run `make lint`, I receive the following logs: ``` go mod...
@whynowy Anything I can add to help get this integrated? I have another patch for the Jetstream sensor stability & availability improvements that I'd like to open a PR for,...
> Some extra blank lines. Hmmm... I don't think I am following. Looking at the diff, I don't believe we added any blank lines to the files that are failing...
> I still need more information about the outdated resourceVersion, for my understanding. I think [this article](https://alenkacz.medium.com/kubernetes-operators-best-practices-understanding-conflict-errors-d05353dff421) provides a nice summary. Consider the following scenario for the current state of...
> Why do you think there's no retry logic, every returned reconciliation error leads to a requeue, did I miss anything? It's been a bit since I looked at it,...
> Considering this is not a corner case, do you know if any other projects had similar problem, and what kind of solution they took? I have not personally run...
@whynowy Is there anything else you need from me here? Would love to get this merged in. Have some other patches that depend on this ready to open.
@whynowy Hey, just checking in here. Anything you need on my end?
As technically I was able to solve the issue, feel free to close it if it doesn't warrant further investigation.