solr-bench
solr-bench copied to clipboard
fullstorydev
cleanup.sh errors out if ZooKeeper not running
A line towards the end of cleanup.sh causes the script to error out if no ZooKeeper process is running on the box:
$ ./cleanup.sh
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
...which comes from the script command:
kill -9 `jps | grep QuorumPeerMain| cut -f 1 -d " "`
Not a major issue, but it'd be a nicer experience if we made this 'kill' command dependent on the jps/grep sub-shell actually producing a pid to terminate.
I noticed this issue on branch ishan/repeatable-jenkins (as of 1d1a3620548ad6a79fc501c1da249f9c9e372a38). I went to go open a PR just now against 'master', but noticed that cleanup.sh is drastically different on that branch and doesn't seem to have the same problem.
Is it worth opening PRs against i/r-j, or should I just close this ticket out since the problem isn't on master? What is i/r-j exactly: a feature branch that aims to merge to 'master' eventually? a long-lived or permanent branch used to integrate with CI? something else?
I found a few other small bugs in code specific to i/r-j (the most signficant of which is that the startup + recovery computed for restart-solr-node tasks is incorrect). Can open PRs for them as well, once I get a little clarification on what the development workflow is here. (i.e. Is i/r-j just a personal branch that @chatman has? Is it a feature branch that's worth fixing bugs on? etc.)
Hi Jason, apologies I couldn't respond earlier due to a wrist injury. I'll get to work soon now. Thanks for your patience.
On Sat, 10 Dec, 2022, 12:40 am Jason Gerlowski, @.***> wrote:
I found a few other small bugs in code specific to i/r-j (the most signficant of which is that the startup + recovery computed for restart-solr-node tasks is incorrect). Can open PRs for them as well, once I get a little clarification on what the development workflow is here. (i.e. Is i/r-j just a personal branch that @chatman https://github.com/chatman has? Is it a feature branch that's worth fixing bugs on? etc.)
— Reply to this email directly, view it on GitHub https://github.com/fullstorydev/solr-bench/issues/31#issuecomment-1344667693, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDCR5CGNLGIYQDUUWL465DWMN72DANCNFSM6AAAAAASZPG5SQ . You are receiving this because you were mentioned.Message ID: @.***>
No worries, and hope your wrist heals up.
Don't rush getting back to work for my sake - I've got the fixes locally so I'm fine. I just wanted to offer them upstream if the intention is that the stuff on ishan/repeatable-jenkins is going to be around for some time or get merged into main, or whatever.
Is it a feature branch that's worth fixing bugs on? etc.)
Yes. It will be merged to main/master soon. It is WIP work on the following PR: https://github.com/fullstorydev/solr-bench/pull/30
Thanks for the startup time calculation bug, fixed it. Feel free to commit directly to that branch, or raise PR against it.