react-native-oauth icon indicating copy to clipboard operation
react-native-oauth copied to clipboard

Extending AuthProviders for auth version 1.0?

Open kengorab opened this issue 8 years ago • 6 comments

Judging from the conversation in #64 it appears that the customization functionality could only be used to add new 2.0 providers. Indeed, looking at the getApiFor10aProvider method in OAuthManagerProviders, it's not possible to add custom 1.0 providers.

At least, not for Android. As best I can tell from reading over the OAuth1Client.m code, any generic oauth 1.0 provider can be configured for iOS.

It appears as though it should just involve adding another method which mimics the OAuth10aService twitterService(...) method (as well as testing, etc). Granted, I've only been reading through this code for the past 25 minutes or so.

Is it on the roadmap for this project to support custom oauth 1.0 providers for Android? I'd be willing to help implement it. Also, please let me know if I've gotten anything wrong in this issue, too.

Thanks!

kengorab avatar Oct 15 '17 02:10 kengorab

@kengorab did you get any news? Are you using an alternative implementation?

corradio avatar Oct 10 '18 15:10 corradio

Yeah, I ended up rolling my own, unfortunately. Sorry, I know that's not very helpful to you

kengorab avatar Oct 10 '18 15:10 kengorab

I did a fork here that supports it partially https://github.com/tmrowco/react-native-oauth

corradio avatar Oct 12 '18 06:10 corradio

@corradio any intentions of finishing your fork? Just by pure luck, I'm also implementing TripIt :D I noticed // TODO: GET THE OAUTH CALLBACK :( I could fork..

kg-currenxie avatar Jun 16 '19 14:06 kg-currenxie

Hi @kg-currenxie,

The fork actually works for TripIt. However, we ended re-implementing everything in javascript and handling the Linking with RCTLinking. We've open sourced part of the code here: https://github.com/tmrowco/tmrowapp-contrib/blob/master/integrations/utils/oauth.js

corradio avatar Jun 18 '19 08:06 corradio

Haha, so did I, also using oauth-1.0a, but got stuck at signing step 3. Thanks for your link, ill check it out :)

kg-currenxie avatar Jun 18 '19 12:06 kg-currenxie