react-native-oauth icon indicating copy to clipboard operation
react-native-oauth copied to clipboard

Google/Facebook sign in page looks like not mobile friendly

Open ujeenator opened this issue 8 years ago • 8 comments

I'm testing on Nexus 5 screen and buttons on Facebook/Google sign in page are out of the screen, and you need to scroll horizontally to press them.

I'm sure there is a mobile friendly version of these pages, recently I have used "react-native-simple-auth" module, it opens same pages not in WebView, but in external browser app, and these pages perfectly fits screen width.

ujeenator avatar Aug 28 '17 18:08 ujeenator

screen shot 2017-08-28 at 10 53 11 pm screen shot 2017-08-28 at 10 52 06 pm

ujeenator avatar Aug 28 '17 19:08 ujeenator

+1

jslok avatar Aug 31 '17 08:08 jslok

+1

tinchogon34 avatar Sep 07 '17 18:09 tinchogon34

Hey, I've made a pull request which I think fixes this - Facebook login is now showing up correctly on my Android device.

Could someone test this for the Google sign in page?

qispark avatar Sep 08 '17 02:09 qispark

I didn't test Google but can confirm @qispark's PR helps a lot. It still has issues on changing orientation but that isn't related to the user agent string being set.

bufke avatar Sep 08 '17 16:09 bufke

@qispark with your change the google sign in page shows the disallowed useragent page and doesn't allow login.

Changing line 112 to mWebView.getSettings().setUserAgentString("Mozilla/5.0 (Linux; Android 6.0.1; SM-G920V Build/MMB29K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.98 Mobile Safari/537.36"); seems to make both facebook and google mobile-friendly on my S6.

jslok avatar Sep 09 '17 07:09 jslok

It looks like there no need to mess around with user agent

Web view already have it own user agent string

I have just commented line that changes webView's user agent and it works perfectly

node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java 112: // mWebView.getSettings().setUserAgentString("Mozilla/5.0 Google");

ujeenator avatar Sep 25 '17 17:09 ujeenator

@ujeenator it seems in latest version on Android platform, you need to change user-agent in node_modules/react-native-oauth/android/src/main/java/io/fullstack/oauth/OAuthManagerDialogFragment.java 112: just like @jslok said. It seems to fix the problem.

iyogeshjoshi avatar Aug 27 '18 13:08 iyogeshjoshi