Fixes for Twitter and Google login on Android

[gvillenave]

[kyle-ssg]

Any chance of this getting merged ? Android twitter auth basically doesn't work without this from what I can see.

[stewartlord]

👍 this should be merged!

[hanalaydrus]

@gvillenave would you mind fixing the conflicts? I hope this will be merged after the conflicts solved.

[gvillenave]

Done!

[f4z3k4s]

This definitely should be merged. Although, line 410: String oauthTokenSecret = (String) accessTokenMap.get("oauth_token_secret"); in android/src/main/java/io/fullstack/oauth/OAuthManagerModule.java should also be dealt with. It casues me a build error(error: cannot find symbol pointing to this line) in case of android release builds, rebased to package version 2.2.0. Apart from that, Twitter finally redirects me to my app. Thanks.

[desktp]

This also fixes crashing on logging in with GitHub. +1 for merging!

[joncursi]

The only issue I see with this is that the location of the authorized key is different on iOS than android. On iOS, you have to check:

if (accessTokenData.response.authorized)

whereas on android, you have to use:

if (accessTokenData.authorized)

The API should be the same across these platforms.

[MBach]

Nice catch @SailingSteve This PR should really be merged into master!

[alejandrosanabriav]

Please merge this, or please maybe if you doesn't has the time to maintain this package pass it to some one how can like react-native-community or some contributor... Thanks for all the effort. I said cause I doesn't seem changes for 4 months ago.

[negebauer]

This should also be deleted

https://github.com/gvillenave/react-native-oauth/blob/4f34e87e99863ba04fe0a11646712ef2b16a28f2/android/src/main/java/io/fullstack/oauth/OAuthManagerModule.java#L410

And also this

https://github.com/gvillenave/react-native-oauth/blob/4f34e87e99863ba04fe0a11646712ef2b16a28f2/android/src/main/java/io/fullstack/oauth/OAuthManagerModule.java#L421