react-native-firestack icon indicating copy to clipboard operation
react-native-firestack copied to clipboard

[v3] Error on auth().updateEmail()

Open skizzo opened this issue 8 years ago • 4 comments

Hi, when trying to call the updateEmail function (branch: v3) (no matter whether with an empty string, or a valid email address), there's an error in lib/utils/index.js in the toWebSDKErrorCode(code, prefix) function:

screen shot 2017-02-24 at 14 13 54

Looks like the code variable is empty.. Could you fix this please? It's not really usable otherwise :) Thanks!

skizzo avatar Feb 24 '17 13:02 skizzo

+1

smkhalsa avatar Mar 01 '17 02:03 smkhalsa

Same goes for signInWithEmailAndPassword(), as soon as a login fails (wrong password), the app crashes with the same error mentioned above. This makes this branch unusable for me..

skizzo avatar Mar 01 '17 10:03 skizzo

@skizzo Seems like this has been a common issue.. I have submitted a PR in regards to discussion happening here : https://github.com/fullstackreact/react-native-firestack/issues/288

The issue is the code in Objective-C is not properly mapped. Javascript in this case expects "code" to be a string but the value passed is actually a long.

jsbranco avatar Mar 08 '17 16:03 jsbranco

@skizzo @smkhalsa @jsbranco fixed over at https://github.com/invertase/react-native-firebase

Its getting hammered with updates and fixes over there, auth is now at 100% implementation on both platforms for example.

Salakar avatar Mar 18 '17 01:03 Salakar