Corrections in docs, auth and database subscription bug fixes for iOS/Android

[abcd-ca]

A couple mistakes in the docs that I tracked down in terms of keys and values for credentials. I have facebook auth working in my app now as a result of these changes (I've verified)

[abcd-ca]

created issue to reference this PR about ref.on('value'...) bug fix

[abcd-ca]

Good catch, I fixed the duplicate line.

On Feb 16, 2017, at 5:35 AM, Victor Munene [email protected] wrote:

@v1kku commented on this pull request.

In lib/modules/auth/index.js https://github.com/fullstackreact/react-native-firestack/pull/284#discussion_r101518594:

@@ -151,7 +151,12 @@ export default class Auth extends Base { * @return {Promise} A promise resolved upon completion */ signInWithCredential(credential: any): Promise<Object> {

• return promisify('signInWithProvider', FirestackAuth)(credential.provider, credential.accessToken, credential.secret);

• signInWithCredential(credential: any): Promise<Object> { @abcd-ca https://github.com/abcd-ca This line is duplicated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fullstackreact/react-native-firestack/pull/284#pullrequestreview-22248759, or mute the thread https://github.com/notifications/unsubscribe-auth/ABPG5ysoPvPP0iQYRn6lsYVN6YEMlWUTks5rdFCtgaJpZM4L7SE_.

[alexkendall]

+1

[JackThomson2]

+1

[Salakar]

@abcd-ca @alexkendall @JackThomson2 this repo has generally been abandoned, I think this issue and a ton of other issues were fixed in my v3 version of firestack.