soniq icon indicating copy to clipboard operation
soniq copied to clipboard

Bug: Do not use Container here

Open davidsparkles opened this issue 5 years ago • 0 comments

Package

  • [ ] I do not know.
  • [ ] auth
  • [ ] boot-loader / graceful-shutdown
  • [ ] config
  • [x] db
  • [ ] events
  • [ ] file-storage
  • [ ] graphql
  • [ ] notifications
  • [ ] queue
  • [ ] schema-builder
  • [ ] server

Describe the bug

When using Container.get outside a function or class, then it is executed as soon the file is loaded. Dependencies should only be loaded, when they are needed. Not in advance. I had problems faking the dependencies cause the import itself made the the Config be constructed and failed the program.

https://github.com/fullstack-build/fullstack-one/blob/master/packages/db/lib/getClientManager.ts#L11

davidsparkles avatar Dec 02 '19 15:12 davidsparkles