universal icon indicating copy to clipboard operation
universal copied to clipboard

language selection is not persistent after page reload

Open saravmajestic opened this issue 8 years ago • 1 comments

I'm submitting a ... (check one with "x")

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ x] Bug report  <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Support request => <!-- Please check the repository for a similar issue or PR before submitting -->
[ ] Feature request
[ ] Documentation issue or request

Current behavior

When I select Turkish language using language menu, after page reload, this state is not saved. ie. it loads English content again.

Expected/desired behavior

Page should load with turkish content

Minimal reproduction of the problem with instructions

  • git clone this repo
  • run npm run serve:watch
  • go to localhost
  • select Turkish language from top toolbar right menu
  • Refresh the browser
  • English content loads after refresh instead of Turkish

Environment

  • Angular version: 4.4.1
  • Browser:
  • [x ] Chrome (desktop) version 60

saravmajestic avatar Sep 22 '17 16:09 saravmajestic

@saravmajestic refreshing the browser actually causes loss of the state. As a result, the language gets reset.

I think you pointed out a good issue, added this to our to-do list. There're several possibilities how we can store this language value (ex: cookie, local-storage, or even on a file at server).

fulls1z3 avatar Sep 26 '17 21:09 fulls1z3