ngx-meta
ngx-meta copied to clipboard
feat(package): migrate to ng12
** PR Type What kind of change does this PR introduce?
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
** What is the current behavior? Does not compile for Angular 12 apps.
Issue Number: N/A
** What is the new behavior?
Should work with Angular 12.
** Does this PR introduce a breaking change?
[ ] Yes
[x] No
Sider has detected 2 warnings on analyzing the commit 4f86860.
If the errors persist even after retrying, the following actions may resolve them:
- Update tool dependencies
- Configure failed tools
-
Configure
sider.yml
- Turn off unused tools
If you still have problems, feel free to ask us via chat. 💬
You can turn off such notifications if unnecessary.
Codecov Report
Merging #215 (4f86860) into master (6329569) will decrease coverage by
0.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
- Coverage 98.75% 98.74% -0.02%
==========================================
Files 7 6 -1
Lines 161 159 -2
Branches 47 49 +2
==========================================
- Hits 159 157 -2
Misses 2 2
Impacted Files | Coverage Δ | |
---|---|---|
packages/@ngx-meta/core/src/index.ts | 100.00% <0.00%> (ø) |
|
...ngx-meta/core/src/models/page-title-positioning.ts |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6329569...4f86860. Read the comment docs.
@fulls1z3 need anything extra for this to be merged?
@fulls1z3 Any news on this? We are really stuf at this point waiting for this lib to support Angular 12.
@JonnyBGod need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)
- https://github.com/fulls1z3/ngx-meta/pull/216
- https://github.com/fulls1z3/ngx-config/pull/169
- https://github.com/fulls1z3/ngx-cache/pull/141
- https://github.com/fulls1z3/ngx-auth/pull/135
and finally we're showcasing it on https://github.com/fulls1z3/universal/pull/755
https://github.com/fulls1z3/ngx-config/pull/168#issuecomment-878080060