ngx-meta
ngx-meta copied to clipboard
fix(package): fixes #208 by compiling without Ivy
** PR Type What kind of change does this PR introduce?
[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
** What is the current behavior? Library can not be used in pre-Ivy projects
Issue Number: #208
** What is the new behavior? Library works in pre-Ivy projects
** Does this PR introduce a breaking change?
[ ] Yes
[x] No
** Other information It's currently not recommended to build libraries with Ivy due to potentially losing support for ViewEngine compiled Angular projects.
Warnings are found on analyzing the commit fee1501.
2 warnings:
We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml
, turn off unused tools, and so on.
If you are struggling with these errors or warnings, feel free to ask us via chat. 💬
Codecov Report
Merging #209 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 7 7
Lines 161 161
Branches 47 47
=======================================
Hits 159 159
Misses 2 2
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 6329569...fee1501. Read the comment docs.
@bhuber2010 need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)
- https://github.com/fulls1z3/ngx-meta/pull/216
- https://github.com/fulls1z3/ngx-config/pull/169
- https://github.com/fulls1z3/ngx-cache/pull/141
- https://github.com/fulls1z3/ngx-auth/pull/135
and finally we're showcasing it on https://github.com/fulls1z3/universal/pull/755