ngx-config icon indicating copy to clipboard operation
ngx-config copied to clipboard

fix(packaging): Disable compiling library with ivy

Open AncelHernandez opened this issue 5 years ago • 3 comments

** PR Checklist Please check if your PR fulfills the following requirements:

  • [ x] The commit message follows our guidelines: https://github.com/fulls1z3/ngx-config/blob/master/CONTRIBUTING.md#commit
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • [x ] Docs have been added / updated (for bug fixes / features)

** PR Type What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

** What is the current behavior?

Issue Number: #163

There is a build error when compiling an application with this library:

ERROR: Error during template compile of 'CoreModule'
  Function calls are not supported in decorators but 'ConfigModule' was called.

** What is the new behavior? No build error. It is not recomended for libraries to be compiled with ivy yet.

Per the CLI:

It is not recommended to publish Ivy libraries to NPM repositories.
Read more here: https://v9.angular.io/guide/ivy#maintaining-library-compatibility

** Does this PR introduce a breaking change?

[ ] Yes
[ x] No

** Other information

AncelHernandez avatar May 28 '20 03:05 AncelHernandez

Warnings are found on analyzing the commit a87acc8.

2 warnings:

We recommend to address them as possible, for example, update outdated dependencies, fix the tool's configuration, configure sider.yml, turn off unused tools, and so on.

If you are struggling with these errors or warnings, feel free to ask us via chat. 💬

ghost avatar May 28 '20 03:05 ghost

Codecov Report

Merging #164 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #164   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files           9        9           
  Lines          91       91           
  Branches       12        9    -3     
=======================================
  Hits           87       87           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5786b9a...a87acc8. Read the comment docs.

codecov[bot] avatar May 28 '20 03:05 codecov[bot]

@AncelHernandez need help with these PR's, especially with ng-packagr is failing. once done aim is first to ng 10 and then eventually to ng11 and ng12 (supporting all intermediate versions)

  • https://github.com/fulls1z3/ngx-meta/pull/216
  • https://github.com/fulls1z3/ngx-config/pull/169
  • https://github.com/fulls1z3/ngx-cache/pull/141
  • https://github.com/fulls1z3/ngx-auth/pull/135

and finally we're showcasing it on https://github.com/fulls1z3/universal/pull/755

fulls1z3 avatar Jul 08 '21 23:07 fulls1z3