keycloak4s icon indicating copy to clipboard operation
keycloak4s copied to clipboard

migrate non-monix modules to cats-effect 3

Open ThijsBroersen opened this issue 3 years ago • 1 comments

I migrated the core modules to cats-effect 3, looks like it is working. Skipped the monix-related modules but perhaps you find this PR a good start to continue the migration on.

ThijsBroersen avatar Oct 13 '21 20:10 ThijsBroersen

Codecov Report

Merging #432 (e6e1491) into develop (d4fe9dc) will decrease coverage by 48.59%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #432       +/-   ##
===========================================
- Coverage    48.59%   0.00%   -48.60%     
===========================================
  Files           77      47       -30     
  Lines         2062    1151      -911     
  Branches         7       6        -1     
===========================================
- Hits          1002       0     -1002     
- Misses        1060    1151       +91     
Impacted Files Coverage Δ
...lfacing/keycloak4s.admin/client/TokenManager.scala 0.00% <0.00%> (-52.81%) :arrow_down:
...fullfacing/keycloak4s.admin/services/package.scala 0.00% <0.00%> (-70.59%) :arrow_down:
...th/akka/http/directives/ValidationDirectives.scala 0.00% <0.00%> (-90.00%) :arrow_down:
.../akka/http/directives/magnets/SecurityMagnet.scala 0.00% <ø> (-100.00%) :arrow_down:
...ycloak4s/auth/core/validation/TokenValidator.scala 0.00% <ø> (-96.08%) :arrow_down:
...m/fullfacing/keycloak4s/core/logging/package.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...m/fullfacing/keycloak4s.admin/services/Roles.scala 0.00% <0.00%> (-100.00%) :arrow_down:
.../fullfacing/keycloak4s.admin/services/Groups.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...llfacing/keycloak4s.admin/services/RolesById.scala 0.00% <0.00%> (-100.00%) :arrow_down:
...facing/keycloak4s/core/models/KeycloakConfig.scala 0.00% <0.00%> (-100.00%) :arrow_down:
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4fe9dc...e6e1491. Read the comment docs.

codecov[bot] avatar Oct 13 '21 20:10 codecov[bot]

Would be great to get this merged. Without Cats Effect 3 support this library is essentially dead :disappointed:

sideeffffect avatar Sep 05 '22 09:09 sideeffffect

Thanks for the message @sideeffffect I have released the cats effect 3 module: keycloak4s-admin-ce3 : 3.2.0

StuartJ45 avatar Sep 16 '22 15:09 StuartJ45