fgpyo icon indicating copy to clipboard operation
fgpyo copied to clipboard

feat: support PEP604 syntax `str | None`

Open nh13 opened this issue 1 year ago • 4 comments

Fixes #89

nh13 avatar Jul 19 '24 18:07 nh13

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 91.37%. Comparing base (0dd300f) to head (345c107). :warning: Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   91.19%   91.37%   +0.17%     
==========================================
  Files          18       18              
  Lines        2351     2364      +13     
  Branches      356      358       +2     
==========================================
+ Hits         2144     2160      +16     
+ Misses        135      134       -1     
+ Partials       72       70       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 19 '24 18:07 codecov[bot]

I don't think I know enough to review this well, so will rely on @msto.

tfenne avatar Jul 22 '24 21:07 tfenne

@msto bump

nh13 avatar Jul 30 '24 22:07 nh13

Walkthrough

The changes involve updates to documentation and type-handling logic. In the fgpyo/util/inspect.py file, the docstring for the list_parser function has been modified to include quotation marks around "stringified." In the fgpyo/util/types.py file, UnionType is now conditionally imported based on the Python version, with a fallback defined for earlier versions. A new type alias, TypeAnnotation, has been introduced, and the _is_optional function has been updated to support multiple syntaxes for optional types, raising a TypeError for invalid inputs. Additionally, new test cases have been added in tests/fgpyo/util/test_types.py to validate these modifications, including parameterized tests for _is_optional and additional assertions for list-like checks, with conditional tests for Python 3.10+ using the updated union syntax.

✨ Finishing Touches
  • [ ] 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Mar 13 '25 04:03 coderabbitai[bot]