websocket-driver icon indicating copy to clipboard operation
websocket-driver copied to clipboard

Replace ironclad with babel and sha1

Open naryl opened this issue 5 years ago • 4 comments

Ironclad is a huge library with huge building problems on ECL. websocket-driver only uses it for two functions. One of them is available from babel which is already included through fast-http, the other one is sha1 hash. There's a library in quicklisp for it but there's a collision with another base64 package.

I've made a PR to the sha1 library ( https://github.com/massung/sha1 ) to use cl-base64 too. You can accept this PR right after my sha1 PR is accepted.

naryl avatar Feb 12 '20 20:02 naryl

The CI fails because the other PR is not accepted yet.

naryl avatar Feb 14 '20 00:02 naryl

LGTM. Thank you for your contribution. I'm waiting for the other PR is merged.

fukamachi avatar Feb 14 '20 08:02 fukamachi

sha1's developer refused to change dependency. I'm investigating other options.

naryl avatar Mar 08 '20 12:03 naryl

I was able to change sha1 remove the base64 dependency altogether. I made a PR #58 which incorporates these changes.

samuel-hunter avatar Aug 26 '21 20:08 samuel-hunter