core icon indicating copy to clipboard operation
core copied to clipboard

\Fuel\Core\Cache_Storage_Driver::get_content_handler - always false cond

Open Illirgway opened this issue 5 years ago • 1 comments

https://github.com/fuel/core/blob/1.9/develop/classes/cache/storage/driver.php#L382

		// When not yet set, use $handler or detect the preferred handler (string = string, otherwise serialize)
		if (empty($this->content_handler) && empty($handler))    // (1)
		{
			if ( ! empty($handler))    // (2)
			{

Due to (1), empty($handler) in (2) is always true, so cond is always false and never fire. I can't understand exactly what this code should do so i can't write fix commit, only issue

Illirgway avatar Sep 25 '19 12:09 Illirgway

if I understand correctly, (2) should simple be moved above (1)

Illirgway avatar Sep 25 '19 12:09 Illirgway