qzxing icon indicating copy to clipboard operation
qzxing copied to clipboard

Add QMLPlugin class for registring as a qml plugin

Open Thaodan opened this issue 7 years ago • 9 comments

This makes QZXing a qml plugin lib to be used as shared qml plugin when qml is enabled. Still wip but ready to use.

Thaodan avatar Apr 11 '19 11:04 Thaodan

No issue the first issue is the one I already noticed. I'll fix the pr soon.

Thaodan avatar Apr 15 '19 09:04 Thaodan

What do yo mean by:

a) merge the same tags (HEADERS, SOURCES) ?

Thaodan avatar Apr 15 '19 10:04 Thaodan

Applied the requested changes

Thaodan avatar Apr 15 '19 10:04 Thaodan

What do yo mean by:

a) merge the same tags (HEADERS, SOURCES) ?

May be i was not clear so i will explain with an example.

Instead of doing this:

HEADERS +=  \
        $$PWD/QZXingImageProvider.h

HEADERS +=  \
        $$PWD/QZXingPlugin.h

you could do this:

HEADERS +=  \
        $$PWD/QZXingImageProvider.h \
        $$PWD/QZXingPlugin.h

ftylitak avatar Apr 16 '19 09:04 ftylitak

should be fixed now.

Thaodan avatar Apr 16 '19 09:04 Thaodan

Anything missing here?

Thaodan avatar May 01 '19 20:05 Thaodan

Do you have time to review the PR again?

Thaodan avatar Jun 14 '19 20:06 Thaodan

Ping?

Thaodan avatar Sep 26 '19 17:09 Thaodan

You will have a reply withing this weakend, sorry for the delay.

ftylitak avatar Sep 27 '19 09:09 ftylitak