theta icon indicating copy to clipboard operation
theta copied to clipboard

Fix Codacy coverage report

Open hajduakos opened this issue 3 years ago • 3 comments

Linux builds are failing due to some Codacy coverage reporting issues.

hajduakos avatar Aug 31 '21 09:08 hajduakos

Seems like it's working on master. But then why did it fail for https://github.com/ftsrg/theta/pull/137? Is it because it was a PR from a separate fork?

hajduakos avatar Sep 01 '21 10:09 hajduakos

This is due to a separate fork I think. It seems logical, because 1) anyone can fork a public repo 2) Actions (and secrets) could be using external (paid) resources.

It is the same with @LendvaiDenes 's PR. (I was talking to him, hence the related PR).

Main issue, I think, is that forks do not get the codacy secrets of the main project.

(I'll reopen the issue, I do not fully understand what it means that it is closed. I think this issue is missing a conclusion. Is this a wontfix, or it is solved as the main project (i.e. not a fork) does not have the issue? )

radl97 avatar Nov 15 '21 14:11 radl97

Yeah, I thought that this is a wontfix, but I agree that it would be nicer to fix so that people have meaningful build results on forks. I know that we can skip certain steps based on branch names, is it also possible to do based on forks? https://github.community/t/how-to-detect-a-pull-request-from-a-fork/18363 seems to give some suggestions

hajduakos avatar Nov 15 '21 14:11 hajduakos