BME-MODES3 icon indicating copy to clipboard operation
BME-MODES3 copied to clipboard

Refactored GPIO to be testable and gradle upgrade

Open ecsedigergo opened this issue 6 years ago • 6 comments

ecsedigergo avatar Oct 05 '18 20:10 ecsedigergo

If I may interrupt, I think version upgrades are not that big a deal

zsoltmazlo avatar Oct 08 '18 19:10 zsoltmazlo

A general question in the end: did you test the changes together with the modules (components) which use the GpioManager? Do these components work correctly after introducing the separate classes for CommandWriter and CommandReader in GpioManager?

benedekh avatar Oct 08 '18 19:10 benedekh

General answer: First of all I did not have yet opportunity and the knowledge to test it, but its true, its necessary before the merge.

ecsedigergo avatar Oct 09 '18 17:10 ecsedigergo

If I may interrupt, I think version upgrades are not that big a deal

@zsoltmazlo There are two issues which might arise:

  1. some internal code might broke within the modules if they heavily rely on some specific features of the dependencies.
  2. every gradle project ought to use the same version of the dependency to avoid incompatibility / inconsistency issues. ('Everyone should be on the same page.' as the saying goes.)

benedekh avatar Oct 11 '18 19:10 benedekh

I wanted to use JUnit 5 and for that I had to upgrade the versions.

ecsedigergo avatar Oct 17 '18 19:10 ecsedigergo

@ecsedigergo Argument is accepted. If it does not cause any compilation (/ runtime) problems, then the version upgrade is good to go.

benedekh avatar Oct 17 '18 21:10 benedekh