bluez
bluez copied to clipboard
Modifications based on the work of @cookj273
Based on the pool request https://github.com/ftonello/bluez/pull/3
- annotations fixed;
- at the beginning waits for an eligible card device's port;
- implemented advertisement using hci functions;
- after the BLE connection done, automatically connect the previously mentioned ALSA port to the "BLE-MIDI Device" one;
- fixed the slow connection time removing the characteristics GATT_CHARAC_DEVICE_NAME, GATT_CHARAC_EXT_PROPER_UUID, GATT_CHARAC_APPEARANCE, GATT_CHARAC_SERVICE_CHANGED and GATT_CLIENT_CHARAC_CFG_UUID. It can be turned on defining ENABLE_EXTRA_CHARACTERISTICS.
Please, make sure you fix basic issues and that you follow the coding style before submiting patches.
- http://git.kernel.org/cgit/bluetooth/bluez.git/tree/doc/coding-style.txt
- https://www.kernel.org/doc/Documentation/process/ specially 4.Coding.rst
Once everything is working properly, I'll make a code refactoring respecting both references. If I do it now, the changes's rastreability turns impossible.
Ok, then you should re-open this pull-request. I will close it for now so we don't get notifications as you change your branch.
I can't reopen it. I have a new commit.
Hi Daniel, I have your branch here and I am basically rewriting most of the code. But we are definitelly in the right direction.
I am doing right now is:
-
TONS of cleanup
- duplicated code
- unnecessary code
- make proper usage of aggregates
- use Linux/POSIX code style
- etc
- Improving the GATT server table
- Remove unecessary characteristics and descriptors
- Add PPCP characteristic
- etc
- Advertise Slave Connection Interval preference
- etc
As soon as I have something I will publish here so you can test as well. Cheers.
@ftonello it looks a very funny rewriting. :-) I'm very interested in getting it working well. It will be a pleasure to test. I'm writing a separate tool for solve my use case (USB-MIDI over BLE-MIDI adapter). Once I test it at night I'll post the link here.