nope-validator
nope-validator copied to clipboard
[Suggestion] add benchmark action to comment on each PR
Question
I was wondering if it makes sense to add an action to run the benchmark for each pull-request, so we can identify if we want or not to merge the change (if it doesn't turn the solution into something so bad, what do you think?
Idea:
- We run the action to test if everthing still working
- We run the
benchmark/index.ts
file and grab all info and send as a comment on the PR, then we can easly understand if make sense or not to merge
I think that's a great idea!
Benchmarks do need a little touchup. Some time should be taken to get the output more reliably and probably add other validation lib test suites to see how we compare to them
Thanks for the suggestion! Makes perfect sense