pytest-ordering icon indicating copy to clipboard operation
pytest-ordering copied to clipboard

Standardize on a single marker name: "order"

Open fmoor opened this issue 8 years ago • 3 comments

Reading the documentation I noticed that there are a lot of potential marker names including run(), and even custom markers proposed in #10. It seems like this has the potential to result in confusing code. Say for instance that some one is new to a project and doesn't know about pytest-ordering. What does the run marker do? Run is a very ambiguous word. I would like to suggest choosing a more specific name. As an option order might be a more intuitive name for someone reading code. The marker signature might look like this: order(pos=None, before=None, after=None).

fmoor avatar May 26 '17 23:05 fmoor

Calling the marker order sounds like a good idea.

ftobia avatar May 29 '17 23:05 ftobia

I've updated the title to describe the proposal. I think a single marker name that takes parameters is a good idea -- though I'm interested to hear feedback from folks if you agree or disagree.

ftobia avatar Oct 09 '19 14:10 ftobia

I like this, and I implemented this in my fork, removing all other special markers.

mrbean-bremen avatar Oct 24 '20 18:10 mrbean-bremen