quickjspp icon indicating copy to clipboard operation
quickjspp copied to clipboard

Published 20 hours ago • verified publisher icon ftk

Updated MSVC branch

Open projectitis opened this issue 2 years ago • 5 comments

Hi FTK. Any chance of an updated MSVC branch? :) i.e. quickjspp.hpp to latest (and other files), and quickjs patches applied? Relates to #23

projectitis avatar Apr 16 '22 07:04 projectitis

I am working on this now.

  • Created new branch off sharedptr called sharedptr-msvc
  • Replaced quickjs subfolder with c-smile's latest code
  • Applied patches from quickjs/patches folder
  • Adding meson build definitions
  • Currently testing

projectitis avatar Apr 17 '22 03:04 projectitis

@ftk could you create a new branch off sharedptr called sharedptr-msvc (or similar) and I'll create a PR for my branch to that. Is that ok?

p.s. My fork has this as the master now.

projectitis avatar Apr 17 '22 06:04 projectitis

Done. https://github.com/ftk/quickjspp/tree/sharedptr-msvc BTW ci and sharedptr branches can be compiled with MSVC (cmake only since it works by downloading a DLL and linking against it)

ftk avatar Apr 17 '22 15:04 ftk

Thanks :)

What is the difference between all the branches? The shared pointer branch has changes that Sam and I were asking about, but what about the ci branch?

Also, what flavor of QuickJS is the dll?

projectitis avatar Apr 17 '22 22:04 projectitis

ci branch only has MSVC-related changes. It's also merged in sharedptr branch but not master branch yet. The dll is vanilla quickjs with quickjspp patches applied, it's however compiled by mingw-w64 since MSVC can't compile quickjs. https://github.com/ftk/quickjspp/actions/runs/2176597938/workflow

ftk avatar Apr 19 '22 11:04 ftk