singleton-ops icon indicating copy to clipboard operation
singleton-ops copied to clipboard

RequireMsgSym[_,_,Info] and more

Open tribbloid opened this issue 4 years ago • 3 comments

This patch has the following 2 changes:

  1. add Info as a validation option for RequireMsgSym

  2. Warn and Info validation options for RequireMsgSym now also invoke scala compiler FontEnds logging.

The purpose of 2 is to allow warning and info logs to be identified by any build & code inspection systems, e.g. bloop language server in the following screenshot:

Screenshot from 2021-04-19 18-17-37

Unfortunately at this moment only INFO seems to be working. WARNING will be omitted by both scalac & bloop. It is probably caused by https://github.com/scala/bug/issues/6910.

If you know the reason for this behaviour please let me know, I'll correct it

tribbloid avatar Apr 19 '21 22:04 tribbloid

Codecov Report

Merging #186 (630137b) into master (f71754a) will decrease coverage by 1.00%. The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   91.57%   90.56%   -1.01%     
==========================================
  Files          10       10              
  Lines         700      710      +10     
  Branches       11        9       -2     
==========================================
+ Hits          641      643       +2     
- Misses         59       67       +8     
Impacted Files Coverage Δ
src/main/scala/singleton/ops/package.scala 100.00% <ø> (ø)
.../main/scala/singleton/ops/impl/GeneralMacros.scala 90.11% <20.00%> (-1.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f71754a...630137b. Read the comment docs.

codecov[bot] avatar Apr 19 '21 22:04 codecov[bot]

Sorry I don't know how to write unit test for this case, It appears that there is no coverage for Warn symbol as well, so I doubt if it could be tested

tribbloid avatar Apr 21 '21 01:04 tribbloid

Thanks for the PR. I'll only have time to review it next month.

soronpo avatar Apr 21 '21 14:04 soronpo