Fab

Results 390 comments of Fab

@jarednorman what would be the most elegant way to solve this? We could spare some time for that.

We don't want to put hands into the work in progress you are doing with the Admin backend, if we take care of the front-end aspects, could you people handle...

@Buvanesh-P Did anybody on your side fix this? > `products_controller_decorator` searching for `Spree::ProductsController` which not exist > > **Steps to reproduce** > > 1. Add the gem `gem 'solidus_reviews'` >...

> > `products_controller_decorator` searching for `Spree::ProductsController` which not exist > > **Steps to reproduce** > > > > 1. Add the gem `gem 'solidus_reviews'` > > 2. `rails generate solidus_reviews:install`...

@jarednorman @kennyadsl please align on desired level of support. For how I see it from the readme.md the old frontend is deprecated and all versions are EOL, am I missing...

> It should be possible to craft this extension such that it can be used with either frontend, but it wouldn't be directly compatible with existing installations without some changes....

To be fully honest three things: - old frontend is deprecated by docs, so let's deprecate it, new versions for gems aligned with the solidus numbering scheme so let's bump...

> No. This is a terrible idea for a number of reasons, including that we would have to ship new versions of every supported gem every time we release a...

@jarednorman One of our first PRs was a complete rewrite of reviews including support for both Frontends and passing tests. Being one of our first PRs the commit structure was...