RxRubyKoans icon indicating copy to clipboard operation
RxRubyKoans copied to clipboard
verified publisher icon fteem

readme review

Open igneus opened this issue 9 years ago • 1 comments

Hi,

I read https://github.com/ReactiveX/RxRuby/issues/79 and quickly tried rxrubykoans.

  1. readme doesn't mention necessity to install dependencies (e.g. by bundle install)
  2. the mention of npm install is probably forgotten from the README of the original JS app?
  3. when I run rake, all tests simply pass. It isn't behavior that I would expect from a "koans" test suite.

igneus avatar Jan 18 '16 16:01 igneus

Hi, thanks for checking out the repo.

The tests are intentionally left passing, so someone with good knowledge of RxRuby can check them out. When it's done, I will fix the test suite, so it works like a proper koans test suite.

I have updated the README, you can check it out.

fteem avatar Jan 18 '16 17:01 fteem