python-ifcfg icon indicating copy to clipboard operation
python-ifcfg copied to clipboard

FreeBSD support

Open mfyuce opened this issue 6 years ago • 7 comments

This library can easily support FreeBSD, I think. Waht do you say?

mfyuce avatar Jun 28 '18 06:06 mfyuce

Thanks for asking

Yes, definitely -- someone (with FreeBSD!) is definitely encouraged to pick up this PR... https://github.com/ftao/python-ifcfg/pull/23

(feel welcome to supersede the PR with your own branch)

benjaoming avatar Jun 28 '18 11:06 benjaoming

Just forked this repo. I'll do this. Not to "up" on nose, but I'll learn. I'll add support for the major BSDs.

rgeorgia avatar Jun 29 '20 01:06 rgeorgia

Excuse my ignorance. Not sure if this is the platform for questions and clarification. I have ifcfg working with FreeBSD and NetBSD (there's a little cliche with OpenBSD). I know almost nothing about nose. If I create a venv with python3.10 nostetests fail with a traceback.

File "/usr/home/rgeorgia/workspace/python_projects/python-ifcfg/venv/lib/python3.10/site-packages/nose/suite.py", line 106, in _set_tests if isinstance(tests, collections.Callable) and not is_suite: AttributeError: module 'collections' has no attribute 'Callable'

All tests pass with python3.8 and python3.9. The tox.ini file has python3.8 as the max version. Are we staying with python3.8?

rgeorgia avatar Mar 20 '22 20:03 rgeorgia

This sounds more like a Python 3.10 issue that should be fixed.

benjaoming avatar Mar 20 '22 20:03 benjaoming

It seems like collections.abc.Callable would work in all Python versions, maybe you can check to see if it does on Python 3.10, too?

benjaoming avatar Mar 20 '22 20:03 benjaoming

Will do! Once I finish the tests (which include learning about nose) I just issue a pull request, correct? I forked the project and created a branch called freebsd.

rgeorgia avatar Mar 20 '22 20:03 rgeorgia

Yes, I'm here to do a new release whenever needed, and @ftao is maybe also on the line :)

benjaoming avatar Mar 20 '22 21:03 benjaoming