luaparse icon indicating copy to clipboard operation
luaparse copied to clipboard

Upgrade the build environment

Open fstirlitz opened this issue 5 years ago • 6 comments

This project has hardly been very keen at keeping up with ~~the Kardashians~~ latest developments in the JavaScript world. As a result, the testsuite has experienced some failures as of late. In particular, the spec repository referred to on the depencency list has disappeared from GitHub; as a stop-gap measure, I switched to version 1.0.1 from npmjs.

An overhaul of the build process is probably long overdue. Suggestions are welcome on how to replace deprecated packages without breaking everything and rewriting the project from scratch.

fstirlitz avatar Aug 16 '19 11:08 fstirlitz

If we drop support of all the obscure environments and runtimes it wouldn't be that be many manually written tests that need that need to be changed if we switched to whatever library. Most of the tests are scaffolded anyways

oxyc avatar Aug 16 '19 18:08 oxyc

Looks like #72 is failing because PhantomJS doesn't support ES6... Can we drop support for PhantomJS? It's no longer maintained.

teoxoy avatar Aug 26 '19 22:08 teoxoy

I think I will drop PhantomJS… and replace it with duktape. It may take some time to set it up under Travis CI, however, so I won't be doing it right away.

fstirlitz avatar Oct 05 '19 06:10 fstirlitz

The more important issue is what to do with spec, however. It is still available from npm and still works, but I don't think it's wise to rely on an unmaintained dependency that may disappear any time soon.

fstirlitz avatar Oct 05 '19 06:10 fstirlitz

You could switch spec for jest or mocha

teoxoy avatar Oct 05 '19 09:10 teoxoy

I upgraded some build dependencies and as of 626f3e4ee6882dd83b8a2b51a6e2c8ecc274840a I managed to shut up npm audit at least. That has to count for something. The issue is still unresolved, though.

fstirlitz avatar Jan 18 '20 11:01 fstirlitz