Felix S.

Results 91 comments of Felix S.

You don't need this patch. ``` bash cat > "${XDG_DATA_HOME:-$HOME/.local/share}/mime/packages/partial-video.xml"

I think I am done for now, but leaving this as draft because this should still not be squashed; each commit should be individually reviewed and cherry-picked. (Actually, I have...

To keep compatibility with upstream pull requests? Right, I can see the concern. (Besides, `DeprecationWarning` is an actual class in Python, supposed to be used in conjunction with the `warnings`...

The upstream maintainers may be asleep at the wheel, but people who haven’t gotten the memo yet (or just stubbornly refuse to switch) are still filing pull requests against the...

> By importing all the submodules in it's `__init__`, we can keep doing `from .utils import ...` while keeping the code more managable Actually, part of the motivation to split...

Of course, code written against `utils` has to keep working. The point is not to _have to_ import everything through `utils`, which will in turn pull in loads of other...

I had to excise `locked_file` conversion from this patch series because it conflicts with #1066. I think `sanitize_open` should be converted into a context manager as well, but that I...

I think some of those are ready and can be cherry-picked as they are: - `.compat` conversion: 9ed27e9690746f9f05dc6e37a31ef526f173186d, d4be2a367cbef3da2d20cbada17aebb1c7217fe6, c45f94c6c70fb9581defe3641e2b0e8f1cb3f817 - 96a9e84287661cbf62c91c7427e1ece6d7e77c8c - 2dda4b0a255ca8209d81589e40efa6b30be53f04 - ea71883d47e2e0180a26b29eb73a38161b1ff344 - 16292448303fe1b91850c194bdb5ebb39fc0de5f - 1de74e8a6b930c97e239539e3db7661ad5986e6e...

> What do you think of directly patching the system modules instead? - Our shims may contain bugs, be incomplete, or slightly deviate from original CPython implementations - Monkey-patching system...

> can probably incorporate your changes when doing that Didn’t make it, I suppose?