Fabian Stäber
Fabian Stäber
Thanks a lot for the detailed analysis and for finding this bug! I agree we should add a `DefaultExports.destroy()` method that can be called from a `ServletContextListener`. Some thoughts on...
Just a shower thought: Maybe there is a way to allow clean-up without an explicit `ServletContextListener`. If we had a wrapper around the listener like this: ```java static class Listener...
Yes, let's go ahead with the `destroy()` method. I'm looking forward to your PR! I thought about the classloader idea again, but it's harder than I thought. It's easy to...
I wrote above > If `MemoryAllocationExports.collect()` is called after `MemoryAllocationExports.destroy()` it should throw an `IllegalStateException` I'm not sure if that's really a good idea. I guess it makes sense if...
:+1: great that you found the unit test. Yes, this is currently the way how to create a `GaugeHistogram`. If you have a proposal for a better API for `GaugeHistogram`,...
Build fails with ``` Error: File is not `gofumpt`-ed with `-extra` (gofumpt) ``` Was that me, or is that an issue with the build pipeline?
Thanks Bryan. I added a comment. Not sure why the linter had failed, but now it's green again.
PR for the trivial fix. I hope I'm not missing anything #1146.
Here's an idea how to debug this: You could try to figure out whether this is caused by a specific JMX bean. Use the `whitelistObjectNames` configuration so that `jmx_exporter` just...
This is weird, an empty `whitelistObjectNames` should result in an empty list of metrics, so I would expect that the response is empty but there should not be an error....