sshfs icon indicating copy to clipboard operation
sshfs copied to clipboard

asyncssh API change breaks parsing of config

Open martijnwgnr opened this issue 2 months ago • 20 comments

The v2.19.0 release of asyncssh has added support for hostname canonicalization. With this change, two new arguments were added to SSHClientConfig.load: canonical and final. We should also pass these parameters in sshfs, because right now the local_user and user are passed in their places, which breaks parsing the config in config.py:

https://github.com/fsspec/sshfs/blob/34b52b241d197a83c085c77ca104888e812283d9/sshfs/config.py#L23-L31

https://github.com/ronf/asyncssh/blob/95756fa4eb54826adb9156b87443d945fd1ed4f8/asyncssh/config.py#L428-L430

martijnwgnr avatar Dec 17 '24 09:12 martijnwgnr